Technical Debt Accumulation
Real Java Code Evolution

package com.company.service; import com.company.model.User; import com.company.repository.UserRepository; /** * Service for handling user operations * Clean, focused, single responsibility */ public class UserService { private final UserRepository userRepository; public UserService(UserRepository userRepository) { this.userRepository = userRepository; } public User findById(Long id) { return userRepository.findById(id); } public User save(User user) { return userRepository.save(user); } }

package com.company.service; import com.company.model.User; import com.company.repository.UserRepository; import java.util.List; import java.util.ArrayList; // TODO: Refactor this class - it's getting too big public class UserService { private final UserRepository userRepository; private EmailService emailService; // Added later public UserService(UserRepository userRepository) { this.userRepository = userRepository; this.emailService = new EmailService(); // Hard dependency! } public User findById(Long id) { return userRepository.findById(id); } public User save(User user) { // Business logic creeping in if (user.getEmail() == null || user.getEmail().isEmpty()) { throw new RuntimeException("Email required"); } User savedUser = userRepository.save(user); // Send welcome email - should this be here? emailService.sendWelcomeEmail(savedUser); return savedUser; } // New requirement: bulk operations public List<User> saveBatch(List<User> users) { List<User> result = new ArrayList<>(); for (User user : users) { // Copy-paste validation logic - DRY violation if (user.getEmail() == null || user.getEmail().isEmpty()) { continue; // Different behavior - inconsistent! } User saved = userRepository.save(user); result.add(saved); } return result; } // New requirement: user validation public boolean validateUser(User user) { // Growing conditional complexity if (user == null) return false; if (user.getName() == null || user.getName().length() < 2) return false; if (user.getAge() < 13 || user.getAge() > 120) return false; return true; } }

package com.company.service; // Multiple imports indicating scattered concerns import com.company.model.User; import com.company.repository.UserRepository; import com.company.external.PaymentService; import com.company.security.SecurityUtils; import java.util.*; import java.time.LocalDateTime; /** * CAUTION: This class has become critical for multiple systems * Changes require approval from: Backend team, Frontend team, DevOps * Last major refactor attempt: Failed (too many dependencies) */ public class UserService { // Growing list of dependencies private final UserRepository userRepository; private EmailService emailService; private PaymentService paymentService; // Why is this here? private SecurityUtils securityUtils; private static final Map<String, String> COUNTRY_CODES = new HashMap<>(); // Static initialization block - red flag! static { COUNTRY_CODES.put("US", "+1"); COUNTRY_CODES.put("UK", "+44"); // ... 50 more countries } public UserService(UserRepository userRepository) { this.userRepository = userRepository; this.emailService = new EmailService(); this.paymentService = new PaymentService(); this.securityUtils = new SecurityUtils(); } /** * WARNING: This method now handles 6 different user types * with 12 different validation rules. Modify with extreme care. */ public User save(User user) { // Nested conditions nightmare if (user == null) { throw new RuntimeException("User cannot be null"); } // Type checking - violates OCP if (user.getType() == UserType.PREMIUM) { if (!paymentService.hasValidPayment(user.getId())) { if (user.getTrialExpiry() != null) { if (user.getTrialExpiry().isBefore(LocalDateTime.now())) { throw new RuntimeException("Payment required for premium user"); } } else { user.setTrialExpiry(LocalDateTime.now().plusDays(7)); } } } else if (user.getType() == UserType.ENTERPRISE) { // More nested logic... if (!securityUtils.validateCorporateEmail(user.getEmail())) { if (user.getCompanyId() == null) { throw new RuntimeException("Enterprise users need company ID"); } } } // Original validation logic scattered throughout if (user.getEmail() == null || user.getEmail().isEmpty()) { throw new RuntimeException("Email required"); } // Phone number validation - why here? if (user.getPhone() != null) { String countryCode = extractCountryCode(user.getPhone()); if (!COUNTRY_CODES.containsValue(countryCode)) { // Log but don't fail - inconsistent behavior System.out.println("Invalid country code: " + countryCode); } } User savedUser = userRepository.save(user); // Side effects everywhere emailService.sendWelcomeEmail(savedUser); updateUserStatistics(savedUser); logUserActivity(savedUser, "CREATED"); return savedUser; } // Helper method that doesn't belong here private String extractCountryCode(String phone) { // 30 lines of regex and string manipulation... return "+1"; // Simplified for demo } // More methods with unclear responsibilities... }

package com.company.service; /** * ⚠️⚠️⚠️ DANGER ZONE ⚠️⚠️⚠️ * * This class is used by: * - User Registration System (Frontend) * - Admin Dashboard (Backend) * - Mobile API (Gateway) * - Batch Processing Jobs (Scheduler) * - Payment Processing (External) * - Reporting System (Analytics) * - Third-party Integrations (Webhooks) * * LAST SUCCESSFUL REFACTOR: Never * FAILED REFACTOR ATTEMPTS: 7 * BUGS INTRODUCED PER CHANGE: 3.2 average * * "Here be dragons" - Previous Tech Lead, 2023 */ import java.util.*; import java.time.*; import java.util.concurrent.*; import java.security.*; import javax.crypto.*; import com.company.*; // 47 more specific imports... @SuppressWarnings({"unchecked", "rawtypes", "deprecation"}) public class UserService { // Global state nightmare private static UserService INSTANCE; // Singleton anti-pattern private volatile Map<String, Object> cache = new ConcurrentHashMap<>(); private ExecutorService threadPool; private Timer cleanupTimer; // 15 different dependencies injected via constructor or setter private UserRepository userRepository; private EmailService emailService; // ... 13 more dependencies /** * The save method that rules them all * 287 lines of pure chaos * Last person to modify: Unknown (git blame shows 47 different authors) */ public User save(User user) throws Exception { // Try-catch blocks within try-catch blocks try { if (user == null) { throw new IllegalArgumentException("User cannot be null"); } // Thread safety concern - but only sometimes synchronized (this) { if (isUserProcessing(user.getId())) { Thread.sleep(100); // Magic number delay return save(user); // Recursive call - stack overflow risk } markUserAsProcessing(user.getId()); } // Type checking with instanceof - LSP violation if (user instanceof PremiumUser) { return handlePremiumUser((PremiumUser) user); } else if (user instanceof EnterpriseUser) { return handleEnterpriseUser((EnterpriseUser) user); } else if (user instanceof TrialUser) { // 47 more lines of nested conditionals... if (user.getType().equals("TRIAL_EXTENDED")) { if (hasExceededTrialLimit(user)) { if (shouldAutoConvert(user)) { try { convertToPaid(user); } catch (PaymentException e) { try { sendPaymentFailureEmail(user); } catch (EmailException emailEx) { // Log and ignore - losing error context logError("Email failed", emailEx); } throw new UserProcessingException( "Payment failed for user: " + user.getId() + ", email notification also failed", e); } } } } } // The actual save is buried deep in the method User savedUser = userRepository.save(user); // Side effects scattered throughout updateCache(savedUser); triggerWebhooks(savedUser); updateAnalytics(savedUser); scheduleCleanupTasks(savedUser); return savedUser; } catch (InterruptedException e) { Thread.currentThread().interrupt(); throw new RuntimeException("Thread interrupted", e); } catch (Exception e) { rollbackUser(user); throw new RuntimeException("User save failed catastrophically", e); } finally { unmarkUserAsProcessing(user.getId()); } } // 31 more methods of varying complexity... // Inner classes for "organization" private static class UserValidationHelper { /* 200 lines */ } private static class PaymentIntegrationHelper { /* 300 lines */ } private static class EmailNotificationHelper { /* 150 lines */ } private static class CacheManager { /* 400 lines */ } }